Attention is currently required from: dexter, laforge, tnt.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email )
Change subject: Add support for sending and receiving Sa bits, as well as some line
signals
......................................................................
Patch Set 4:
(1 comment)
File src/e1_input.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b5261b82_b6e92b5e
PS4, Line 1124: { S_L_INP_LINE_LOF, "LINE-LOF" },
: { S_L_INP_LINE_NOLOF, "LINE-NOLOF" },
Makes sense to me. […]
I already had the
loss-of-frame event in a previous patchset of osmo-e1d. as @tnt@246tNt.com already
mentioned, it is wrong indication. from application's view it does not matter, but it
is useful for the user to troubleshoot a bad link. LOS/LOF/AIS may have all different
causes.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie7643693c2daac99f5747591decd60e982b8052a
Gerrit-Change-Number: 35563
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 15:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment