Attention is currently required from: fixeria, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email )
Change subject: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/35312/comment/230870b1_dad5ec7e
PS1, Line 284: /*! Get remaining space for characters and terminating nul in the given struct osmo_strbuf.
I'd expect the linker will throw out any unused functions anyway. […]
Note that my comment doesn's take a position on whether or not it should be an inline function. I'm just saying repeat compilation + drop by linker if unneeded is not a problem.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I294a74a99c40995cf7fb5520d61f697d967be5a4
Gerrit-Change-Number: 35312
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 17 Dec 2023 10:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment