Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted ......................................................................
Patch Set 1:
(2 comments)
File src/sbcap_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/de5bc368_4127b1c9 PS1, Line 397: Transmitting
Given that you're changing "Received" to "Rx", I suggest to use "Tx" here for consistency.
Ack
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/88b42868_4a92312f PS1, Line 403: LOGPSBCAPC(link, LOGL_DEBUG, "Encoded message %s: %s\n",
Isn't it redundant to print PDU name here? […]
Yes, I'm printing it as debug after encoding it, this is helpful to find out that it was encoded successfuly.