Attention is currently required from: fixeria.

View Change

2 comments:

• File src/sbcap_link.c:

  • Patch Set #1, Line 397: Transmitting

    Given that you're changing "Received" to "Rx", I suggest to use "Tx" here for consistency.

    Ack

  • Patch Set #1, Line 403: LOGPSBCAPC(link, LOGL_DEBUG, "Encoded message %s: %s\n",

    Isn't it redundant to print PDU name here? […]

    Yes, I'm printing it as debug after encoding it, this is helpful to find out that it was encoded successfuly.

To view, visit change 28819. To unsubscribe, or for help writing mail filters, visit settings.