Attention is currently required from: Hoernchen, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32022 )
Change subject: layer23: modem: Test GMM layer through VTY ......................................................................
Patch Set 1:
(4 comments)
File src/host/layer23/src/modem/gmm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/3079976d_7a585119 PS1, Line 92: rc = 1;
Just do `return 1` straight away, `rc` is not really needed?
It's still handy to check returned value while debugging. I see no real problem with this.
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/2f199d27_3409bbe9 PS1, Line 62: rc = osmo_gprs_gmm_prim_llc_lower_up(llc_prim);
Same here, you're assigning `rc` but then unconditionally overwriting it?
Good for debugging, so you can print rc here.
File src/host/layer23/src/modem/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/10eb59d5_42a4360e PS1, Line 159: LLC_CMDG_DESC
copy-paste, you should add `GMM_CMDG_DESC`.
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/04d91535_effa0781 PS1, Line 161: "Hard-coded GMM Attach Request (SAPI=GMM, TLLI=0xe1c5d364)\n")
Something is wrong here, what part of the command this docstring corresponds to?
Ack