Attention is currently required from: Hoernchen, fixeria.

View Change

4 comments:

• File src/host/layer23/src/modem/gmm.c:

  • Patch Set #1, Line 92: rc = 1;

    Just do `return 1` straight away, `rc` is not really needed?

    It's still handy to check returned value while debugging. I see no real problem with this.

• File src/host/layer23/src/modem/llc.c:

  • Patch Set #1, Line 62: rc = osmo_gprs_gmm_prim_llc_lower_up(llc_prim);

    Same here, you're assigning `rc` but then unconditionally overwriting it?

    Good for debugging, so you can print rc here.

• File src/host/layer23/src/modem/vty.c:

  • Patch Set #1, Line 159: LLC_CMDG_DESC

    copy-paste, you should add `GMM_CMDG_DESC`.

    Ack

  • Patch Set #1, Line 161: "Hard-coded GMM Attach Request (SAPI=GMM, TLLI=0xe1c5d364)\n")

    Something is wrong here, what part of the command this docstring corresponds to?

    Ack

To view, visit change 32022. To unsubscribe, or for help writing mail filters, visit settings.