Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email )
Change subject: add fw update crcstub
......................................................................
Patch Set 12:
(2 comments)
File crc_code.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ca6428e5_5ae9e5d… :
PS10, Line 102: // uint32_t length = strtoul(argv[3], NULL, 16);
can this commented out code be removed? I guess every
C developer knows that diferent base arguments […]
Done
File crc_params.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/67c3abd4_39ba744… :
PS10, Line 5: // __attribute__((used, section(".crc_par"))) const uint32_t
__CRC_End = 0xFFFFFFFF; /* Placeholder */
why do we have this commented-out code here? is this
some earlier attempts? shouldn't it be removed?
those still exist in the ld file
and might be needed in case the linker, gcc, make, objdump, objcopy, or any other part of
this brittle house of cards breaks again and I need anther approach to patch the files.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed
Gerrit-Change-Number: 39437
Gerrit-PatchSet: 12
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Mar 2025 12:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>