Attention is currently required from: laforge.

View Change

2 comments:

• File crc_code.c:

  • Patch Set #10, Line 102: // uint32_t length = strtoul(argv[3], NULL, 16);

    can this commented out code be removed? I guess every C developer knows that diferent base arguments […]

    Done

• File crc_params.c:

  • Patch Set #10, Line 5: // __attribute__((used, section(".crc_par"))) const uint32_t __CRC_End = 0xFFFFFFFF; /* Placeholder */

    why do we have this commented-out code here? is this some earlier attempts? shouldn't it be removed?

    those still exist in the ld file and might be needed in case the linker, gcc, make, objdump, objcopy, or any other part of this brittle house of cards breaks again and I need anther approach to patch the files.

To view, visit change 39437. To unsubscribe, or for help writing mail filters, visit settings.