[M] Change in libosmocore[master]: CTRL: get rate_ctr_group by the id from rate_ctr_group_set_name()

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email ) Change subject: CTRL: get rate_ctr_group by the id from rate_ctr_group_set_name() ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: I've been thinking about the main purpose for this: our test suite. "proper" users would use the stats export instead. In that light, it seems we should just accept the inefficient lookup. Aaand, I wonder if we should drop this patch (and the ttcn3 CTRL patch) entirely and instead use the stats exporter in HNBGW_Tests.ttcn to verify counters. We already have the StatsD_Checker.ttcn, shouldn't be too much effort to build on that? i.e. move away from CTRL instead of spending time on its quirks. The only thing in my mind against this is that the CTRL patch is already done now, and changing HNBGW_Tests.ttcn to stats is basically a whole new task. thoughts? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Gerrit-Change-Number: 37881 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2024 00:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>