Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
......................................................................
Patch Set 3: Code-Review-1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/c726a8d9_a959a778
PS3, Line 15: used
use
File src/libosmo-pfcp/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/598a6047_c54ca009
PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS
erm ok, of course there is some linking phase for the
library and it has LDFLAGS. […]
I still don't like changing `_LDADD` to
`_LDFLAGS`. The author of this patch
https://lore.kernel.org/all/20181118160802.11087-4-jengelh@inai.de/ explains that having
-l arguments (i.e. `*_LIBS`) in `LDFLAGS` is wrong.
I guess the problem was that initially you had `AM_LDFLAGS` with `*_LIBS` in there -- this
is wrong because the `LDFLAGS` do appear earlier in the linker's command line than
`LDADD`. Now that you have removed the `AM_LDFLAGS`, I think it should work as expected
without the need to change `_LDADD` to `_LDFLAGS`.
File src/libosmo-pfcp/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/f860ed82_cedfa358
PS3, Line 71: COVERAGE_LDFLAGS
This does not belong here and should be done in
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31761.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
Gerrit-Change-Number: 31741
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 08:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment