Attention is currently required from: neels, pespin.
Patch set 3:Code-Review -1
3 comments:
Commit Message:
use
File src/libosmo-pfcp/Makefile.am:
Patch Set #1, Line 68: gen__pfcp_ies_auto_LDFLAGS
erm ok, of course there is some linking phase for the library and it has LDFLAGS. […]
I still don't like changing `_LDADD` to `_LDFLAGS`. The author of this patch https://lore.kernel.org/all/20181118160802.11087-4-jengelh@inai.de/ explains that having -l arguments (i.e. `*_LIBS`) in `LDFLAGS` is wrong.
I guess the problem was that initially you had `AM_LDFLAGS` with `*_LIBS` in there -- this is wrong because the `LDFLAGS` do appear earlier in the linker's command line than `LDADD`. Now that you have removed the `AM_LDFLAGS`, I think it should work as expected without the need to change `_LDADD` to `_LDFLAGS`.
File src/libosmo-pfcp/Makefile.am:
Patch Set #3, Line 71: COVERAGE_LDFLAGS
This does not belong here and should be done in https://gerrit.osmocom.org/c/libosmo-pfcp/+/31761.
To view, visit change 31741. To unsubscribe, or for help writing mail filters, visit settings.