Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37497?usp=email )
Change subject: osmo-smdpp: Make sure to return empty HTTP response in handleNotification
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/37497/comment/cbce0dad_421d1a0f
PS2, Line 191: return ''
May it makes sens to print something like "Tx (empty response)" for consistency?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37497?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1cad539accbc3e7222bfd4780955b3b1ff694c5b
Gerrit-Change-Number: 37497
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Wed, 17 Jul 2024 13:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment