[M] Change in osmo-hnbgw[master]: Introduce concept of per-HNB persistent data structure

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081?usp=email ) Change subject: Introduce concept of per-HNB persistent data structure ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: I File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081/comment/5a0ae855_8205f5d7 PS2, Line 825: "hnb UMTS_CELL_ID", Ack fine then. But the fact that xxx-yyy-Llac-Rrac-Ssac-Ccid needs to be passed as a string in VTY is a bit weird imho, since you are basically skipping the "vty parameter" functionality that VTY provides, which makes it easier for user to figure out each field by introspecting, etc. Also not blocking, but I have to say I'm not really liking this concept of "persistent structure" you are adding. I'd probably go for something more similar to what we do with ASPs in libosmo-sccp. The same structure is used to handle everything related to that entity, and if it is dynamically created then a "hnb->dynamic=true" is added to it, so that it is not written back to the config file. Maybe the problem is that we shouldn't be destroying the other structure upon reconnect, even for dynamic ones. The difference is that dynamic ones become gone once the process exits. Maybe the problem is that hnb_context should be renamed to hnb_conn and your persistent one be named hnb_context or simply "hnb". -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ife89a7a206836bd89334d19d3cf8c92969dd74de Gerrit-Change-Number: 36081 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 07 Mar 2024 17:54:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment