Attention is currently required from: pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/29752 )
Change subject: SNDCP: add LLE-specific logging wrapper
......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_sndcp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/29752/comment/24a35606_a1de6032
PS4, Line 225: (LLE)->llme->tlli, (LLE)->sapi, (NSAPI),
llist_count(&gprs_sndcp_entities), ##ARGS)
I don't see this macro using LOGL_ERROR, but a
LEVEL field, which means will be used for any logging […]
It'll be used with log
levels specified in the patch - you can read it and see with which log level it's
mostly used. I think it's valuable to print this count where the macro is called -
that's why I've submitted this patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/29752
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Idfab1f4be034fc8eab8f87bd8cd88723939e107e
Gerrit-Change-Number: 29752
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 14:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment