Attention is currently required from: arehbein, dexter, laforge, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email )
Change subject: bsc: Make socket queue max. length configurable
......................................................................
Patch Set 8:
(2 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/ef46c6d0_758599ad
PS8, Line 2499: size_t to = (net->pcu_sock_wqueue_len_max = atoi(argv[0]));
this new variable is really not needed and just makes
everything more complex, specially with the pa […]
Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/450acc4e_c0e41486
PS8, Line 2503: LOGP(DPCU, LOGL_INFO, "Have dropped %zu messages due to shortened
max. message queue size (from: %zu to %zu)\n",
it may be good to do vty_out with the same message
here, to show the user of the VTY what happened a […]
ACK
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b
Gerrit-Change-Number: 33892
Gerrit-PatchSet: 8
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Nov 2023 10:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment