[L] Change in osmocom-bb[master]: layer23: Introduce apn_fsm

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32596 ) Change subject: layer23: Introduce apn_fsm ...................................................................... Patch Set 2: (2 comments) File src/host/layer23/src/common/apn_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32596/comment/0a01b0bc_e042f00c PS2, Line 103: apn_fsm_state_chg(fi, APN_ST_DISABLED); Don't we need to check *((bool *)data)? I guess the assumption is that it is false here, as I understand the BTS/other layers would send that to disable the APN, and then later on send it again with true to enable it again? Same for st_apn_active(). https://gerrit.osmocom.org/c/osmocom-bb/+/32596/comment/b52edfe0_a75fe921 PS2, Line 139: apn_fsm_state_chg(fi, APN_ST_INACTIVE); * is this correct, receiving CTX_ACC and then going to inactive here? * what about APN_EV_RX_SM_ACT_PDP_CTX_REJ? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2cc732dfb020d31ab89025e7e22276b819dcb24a Gerrit-Change-Number: 32596 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 May 2023 10:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment