Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

Attention is currently required from: neels, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 10: (4 comments) File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/770beaf1_4164d9eb PS4, Line 98: && net->bts_setup_ramp.step_size > 0 Ack https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/123f401e_89c5bcf1 PS4, Line 101: net->bts_setup_ramp.active The point is to use the API here so that if you/anyone changes the API implementtion you don't need to find out where to apply this in different sides of the code ;) But fine with how it is now, not a big problem. File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/967391ea_18dae2f9 PS10, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr) This is till wrong and has not been addressed. You now call configure_loop from two states, I'd welcome if you added the opstart param here so that it looks similar to the other FSMs and it is easier to extend in the future without screwing the transitions. File src/osmo-bsc/nm_channel_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/30e93c88_9d61475d PS10, Line 224: configure_loop(ts, &ts->mo.nm_state, false); this is wrong, it should be "true". -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Oct 2022 09:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment