Attention is currently required from: neels, fixeria, lynxis lazus.

View Change

4 comments:

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #4, Line 98: && net->bts_setup_ramp.step_size > 0

    Extra spacing makes this construct hard to read. Please align properly.

    Ack

  • Patch Set #4, Line 101: net->bts_setup_ramp.active

    because it's a single line. If ramp_active() is checking more, i'll use it here too.

    The point is to use the API here so that if you/anyone changes the API implementtion you don't need to find out where to apply this in different sides of the code ;) But fine with how it is now, not a big problem.

• File src/osmo-bsc/nm_bts_sm_fsm.c:

  • Patch Set #10, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr)

    This is till wrong and has not been addressed. You now call configure_loop from two states, I'd welcome if you added the opstart param here so that it looks similar to the other FSMs and it is easier to extend in the future without screwing the transitions.

• File src/osmo-bsc/nm_channel_fsm.c:

  • Patch Set #10, Line 224: configure_loop(ts, &ts->mo.nm_state, false);

    this is wrong, it should be "true".

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.