Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30138 )
Change subject: rspro_client: implement re-establish delay ......................................................................
Patch Set 1:
(2 comments)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/9f88aba0_882f1d83 PS1, Line 227: const I had no idea you can use 'const' this way. I only knew it in the context of 'static const', i.e. stuff for the linker to put into read-only memory, and as 'const void/char/... *' in argument lists.
More than 25 years of C develoment and I didn't know about this...
https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/a8c9ad40_28ff6baa PS1, Line 236: LOGPFS I am not sure those are worth LOGL_NOTICE. Looks more like a DEBUG or if at all INFO level message to me.
NOTICE is something the normal user absolutely should be informed about, but which is not an ERROR yet.