Attention is currently required from: jtavares.

View Change

2 comments:

• File src/rspro_client_fsm.c:

  • Patch Set #1, Line 227: const

    I had no idea you can use 'const' this way. I only knew it in the context of 'static const', i.e. stuff for the linker to put into read-only memory, and as 'const void/char/... *' in argument lists.

    More than 25 years of C develoment and I didn't know about this...

  • Patch Set #1, Line 236: LOGPFS

    I am not sure those are worth LOGL_NOTICE. Looks more like a DEBUG or if at all INFO level message to me.

    NOTICE is something the normal user absolutely should be informed about, but which is not an ERROR yet.

To view, visit change 30138. To unsubscribe, or for help writing mail filters, visit settings.