Attention is currently required from: arehbein, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 )
Change subject: gsm_objclass2obj(): Change signature/set NACK cause ......................................................................
Patch Set 2:
(2 comments)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/a5be9d45_37bf991d PS2, Line 537: enum abis_nm_nack_cause c; This should be in the previous commit.
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/3a954629_b6355056 PS2, Line 1106: gsm_objclass2obj
This call may overwrite the cause previously set by `gsm_objclass2mo()`. […]
Ack. On the other hand, if one fails the other should fail the same too, so no big problem in practice. BUt yeah, let's check it wice anyway to be more clear.