Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34140 )
Change subject: l1gprs: Fix slotmask update on already registered tbf
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/shared/l1gprs.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/78e72881_386017d5
PS1, Line 142: pdch->tn
Using scoped variable `tn` would make the code a bit
shorter. […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/57aacd4a_77ab191a
PS1, Line 155: TS%u
`LOGP_PDCH` does print timeslot number, printing it
again is redundant.
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/3e2f0451_8cc7a14b
PS1, Line 165: TS%u
Same here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34140
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5d64488d2aa740e91e01fad17f2af3ded24b12ef
Gerrit-Change-Number: 34140
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Aug 2023 17:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment