Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email )
Change subject: libvlr: replace direct call of paging_expired() into a callback ......................................................................
Patch Set 2:
(1 comment)
File src/libmsc/sgs_iface.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38107/comment/ec0738da_fd3a1e41?usp=... : PS2, Line 473: int sgs_iface_tx_paging(struct vlr_subscr *vsub, enum sgsap_service_ind serv_ind)
@pespin as alternative, I could add a second callback to the SGS/VLR? I don't have a strong opinion […]
I don't know all this code well enough to say. I think it's fine having it together, but I don't have a strong opinion. In any case, at least update the code as I mentioned.