Attention is currently required from: neels, msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30960 )
Change subject: Move osmocom_ms to a separate file
......................................................................
Patch Set 5:
(3 comments)
File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/f7ec82d1_192e00de
PS5, Line 3: #include <stdint.h>
the above are unrelated changes sneaking into this
patch
why do you say so? when the structs holding most of the include dependencies
are moved from here, one still needs to keep the required includes here. That's what
I'm doing.
In any case the change in this file is so big that it can be considered I'm rewriting
the general structure of the file and hence it's file simply changing to use the
pragma once here.
I see no point in having to do an extra commit for that here.
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/936a1400_85081bb1
PS5, Line 271: ms = osmocom_ms_alloc(l23_ctx);
(ack, IMO would suffice to OSMO_ASSERT(ms) either here
or in osmocom_ms_alloc())
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/0d4cc51b_59a742bb
PS5, Line 272: llist_add_tail(&ms->entity, &ms_list);
i see now you are moving it in a later patch. […]
I prefer keeping it in smaller chunks, iterative changes.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30960
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icb4891cc1e4a0ecb5f09cb8a84b0ebe1b91a46b8
Gerrit-Change-Number: 30960
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Jan 2023 09:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment