Attention is currently required from: neels, msuraev.

View Change

3 comments:

• File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:

  • Patch Set #5, Line 3: #include <stdint.h>

    the above are unrelated changes sneaking into this patch

    why do you say so? when the structs holding most of the include dependencies are moved from here, one still needs to keep the required includes here. That's what I'm doing.
    In any case the change in this file is so big that it can be considered I'm rewriting the general structure of the file and hence it's file simply changing to use the pragma once here.
    I see no point in having to do an extra commit for that here.

• File src/host/layer23/src/common/main.c:

  • Patch Set #5, Line 271: ms = osmocom_ms_alloc(l23_ctx);

    (ack, IMO would suffice to OSMO_ASSERT(ms) either here or in osmocom_ms_alloc())

    Ack

  • Patch Set #5, Line 272: llist_add_tail(&ms->entity, &ms_list);

    i see now you are moving it in a later patch. […]

    I prefer keeping it in smaller chunks, iterative changes.

To view, visit change 30960. To unsubscribe, or for help writing mail filters, visit settings.