23 Jul
2024
23 Jul
'24
11:57 a.m.
Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email )
Change subject: pcuif_sock: do not retry when sending PCU version ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/pcuif_sock.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/37548/comment/7e3fee9a_b5c1f001 PS2, Line 245: osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); And I guess you also need to remove the timer from the struct now that it's not used anymore?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126
Gerrit-Change-Number: 37548
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 23 Jul 2024 09:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment