fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27862 )
Change subject: utils/meas_db: fix -Wunused-variable warnings ......................................................................
utils/meas_db: fix -Wunused-variable warnings
When building with CFLAGS="-flto -Wall", I get the following:
meas_db.c: In function ‘_insert_ud’: meas_db.c:62:23: warning: unused variable ‘rowid’ [-Wunused-variable] 62 | unsigned long rowid; meas_db.c: In function ‘meas_db_insert’: meas_db.c:89:13: warning: unused variable ‘rc’ [-Wunused-variable] 89 | int rc; meas_db.c: In function ‘check_create_tbl’: meas_db.c:260:16: warning: unused variable ‘rc’ [-Wunused-variable] 260 | int i, rc;
Change-Id: Id12958f67a47b6b3ebece7252e4f7c0835d4bb96 --- M src/utils/meas_db.c 1 file changed, 1 insertion(+), 4 deletions(-)
Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/utils/meas_db.c b/src/utils/meas_db.c index 4fc2916..bf3a093 100644 --- a/src/utils/meas_db.c +++ b/src/utils/meas_db.c @@ -59,8 +59,6 @@ static int _insert_ud(struct meas_db_state *st, unsigned long meas_id, int dtx, int uplink, const struct gsm_meas_rep_unidir *ud) { - unsigned long rowid; - SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_ud, 1, meas_id)); SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_ud, 2, rxlev2dbm(ud->full.rx_lev))); @@ -86,7 +84,6 @@ const char *scenario, const struct gsm_meas_rep *mr) { - int rc; sqlite3_int64 rowid, ul_rowid, dl_rowid;
SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_mr, 1, timestamp)); @@ -257,7 +254,7 @@
static int check_create_tbl(struct meas_db_state *st) { - int i, rc; + int i;
for (i = 0; i < ARRAY_SIZE(create_stmts); i++) { SCK_OK(st->db, sqlite3_exec(st->db, create_stmts[i],
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.