10 Sep
2024
10 Sep
'24
8:34 p.m.
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38085?usp=email )
Change subject: gsm_bts_num(): use hashtable to lookup bts ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/38085/comment/efa25ef4_c4573455?usp=... : PS1, Line 990: 6 why only 6? In very small lab type setups, a few more hash buckets will not matter performance-wise. In large setups, we know the number of BTS will be >256 soon, and hence I'd have suggested at least 8 bits or more here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38085?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7312da7d9aa80c6d0f2e92e9c7d20d32ce453ad1
Gerrit-Change-Number: 38085
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 10 Sep 2024 18:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes