Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email )
Change subject: mobile: integrate V.110 TA & soft-UART from libosmocore
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
Re-applying Harald's and Oliver's votes.
File src/host/layer23/src/mobile/tch_data.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/ad04bc5b_115143f2
PS6, Line 323: nmsg->l2h = msgb_put(nmsg, 33); /* XXX: proper size */
what about this?
The firmware [for Calypso] is
expecting all `TRAFFIC.req` to contain 33 bytes, regardless of the channel type. This
should be fixed in a separate patch, I am just adding a comment.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0
Gerrit-Change-Number: 35582
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jan 2024 19:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment