Attention is currently required from: rauf.gyulaliev@fairwaves.co, ipse, pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )
Change subject: Initial XTRX support
......................................................................
Patch Set 3:
(3 comments)
File Transceiver52M/device/xtrx/XTRXDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/c6de38f7_ef0b9e67
PS1, Line 177: return false;
Other device implementations. For instance UHDDevice does: […]
Done
File Transceiver52M/device/xtrx/XTRXDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/47debce2_5df9dcd8
PS3, Line 459:
Remove extra whitespace at the end.
Done
File contrib/systemd/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/0c9e9017_1ccf18fe
PS3, Line 4: osmo-trx-usrp1.service
You miss adding osmo-trx-xtrx.service here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulaliev@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse
Alexander.Chemeris@gmail.com
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: rauf.gyulaliev@fairwaves.co
Gerrit-Attention: ipse
Alexander.Chemeris@gmail.com
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 08 Aug 2022 18:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ipse
Alexander.Chemeris@gmail.com
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
