Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email )
Change subject: tests: sanitize all cards before running tests ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
Do we have some information how much time the restore of all cards takes?
I now did a test run with a stopwatch to measure this. It takes 7:31 for all 7 cards. I wonder if there is any logic that would allow us to run the sanitizer only on the first patch (the one closest to master) of a patch set.
File tests/card_sanitizer/card_sanitizer.py:
https://gerrit.osmocom.org/c/pysim/+/38254/comment/b82378c6_30570f01?usp=ema... : PS1, Line 33: from smartcard.CardType import ATRCardType : from smartcard.CardRequest import CardRequest : fr
unused imports
Done
File tests/card_sanitizer/restore.script:
https://gerrit.osmocom.org/c/pysim/+/38254/comment/418e4c78_e9bbb182?usp=ema... : PS1, Line 3: ru
I don't like this approach with a global file in /var/tmp. […]
That was a good idea, it simplifies things a lot.