[S] Change in osmocom-bb[master]: layer23: Store and use SAPI & NSAPI in apn->pdp

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32597 ) Change subject: layer23: Store and use SAPI & NSAPI in apn->pdp ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/modem/sndcp.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32597/comment/f0f313c7_adaa3d16 PS1, Line 183: uint32_t tlli = 0xe1c5d364; I think I can retrieve it in the hook/forward of SNSM-ACTIVATE.ind/cnf in sndcp.c In there I get NSAPI, SAPI, and TLLI, check 3GPP TS 44.065. our libosmo-gprs-sm seems to be wrong and passing PTMSI instead: gprs_sm_submit_snsm_act_ind() { ... sndcp_prim_tx = osmo_gprs_sndcp_prim_alloc_snsm_activate_ind( sme->ms->gmm.ptmsi, sme->nsapi, sme->llc_sapi); ... } Actually the whole SM layer seems to still use PTMSI vs TLLI the wrong way? """ struct gprs_sm_ms *gprs_sm_find_ms_by_tlli(uint32_t tlli) { struct gprs_sm_ms *ms; llist_for_each_entry(ms, &g_sm_ctx->ms_list, list) { if (ms->gmm.ptmsi == tlli) return ms; } return NULL; } """ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If82c94ca9c84a94e63a9a5d642a27a7b4e3ff089 Gerrit-Change-Number: 32597 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 03 May 2023 19:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment