Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/38117?usp=email )
Change subject: ts_51_011: replace encoding of EF.MSISDN with construct model
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Interesting: The construct version on the tester was 2.10.68, on my workstation where the
pySim-trace test is passing it was 2.10.70. Presumably this older version has problems to
evaluate the COptional correctly and was letting 0xFF bytes into the GSM0338 decoder.
Also the file contents in the trace look wild:
ff0791942143658709ffffffffffffffffffffffffffffffffffffffffffffffffff
In any case, the decoding works now!
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38117?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a
Gerrit-Change-Number: 38117
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 18 Sep 2024 12:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No