Attention is currently required from: daniel, pespin.
neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email )
Change subject: mgw: MDCX: Split mgcp header pars parsing into a previous step ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/e689712d_c3e21e85?usp=... : PS4, Line 1115: /* Reset conn mode in case it was tweaked through VTY: */
Yeah, something else which kinda sucks a bit: […]
i think i get it now, the vty might have changed the conn mode, and the peer still assumes that the previously sent mode is in place. So on the next MGCP, re-instate the peer's mode and discard the vty mode, even if no new explicit mode is present. (maybe i should add this to that comment...)