17 Dec
2023
17 Dec
'23
2:11 p.m.
Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/35254?usp=email )
Change subject: tlv: improve flatten_dict_lists for multiple keys
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
The problem with appending suffixes is that it will be hard to do the inverse
transformation during encode (which is required for the usual TLV encoder/decoders used
for various EF content. Deciding the SELECT response is one of the very rare cases where
we don't need to encode.
Also, I don't see the problem you're describing as example. See:
pySIM-shell (00:MF)> select MF
{
"file_descriptor": {
"file_descriptor_byte": {
"shareable": true,
"file_type": "df",
"structure": "no_info_given"
},
"record_len": null,
"num_of_rec": null
},
"file_identifier": "3f00",
"proprietary_information": {
"uicc_characteristics": "71",
"available_memory": 354512,
"supported_filesystem_commands": {
"terminal_capability": true
}
},
"life_cycle_status_integer": "operational_activated",
"security_attrib_compact": "261a0000",
"pin_status_template_do": [
{
"ps_do": "70"
},
{
"key_reference": 1
},
{
"key_reference": 129
},
{
"key_reference": 10
},
{
"key_reference": 11
}
]
It does already show all four key_reference.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35254?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie3b418ca3965b0221bbf5f85d7d0e0fbb39d9d87
Gerrit-Change-Number: 35254
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Dec 2023 13:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment