Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40291?usp=email )
Change subject: sccp: SCOC -> SCRC: Delay called addr lookup until needed [2/3] ......................................................................
Patch Set 1:
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40291/comment/9c534268_265f5f... : PS1, Line 464: if (0) {
I know you just moved this, but this is commented out code without the actual comments (and also exa […]
I actually prefer keeping it this way without touching it, it denotes better we really have a whole block from the diagram missing there. Because what we are actually missing is the condition check which is a new function. Having the call to scrc_node_2() there forces us to take it into account when refactoring code, like I did now.