Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 )
Change subject: pcu_l1_if_phy: flexible phy access ......................................................................
Patch Set 2:
(5 comments)
File src/pcu_l1_if_phy.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3662): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/433d9bd2_e672e18b PS2, Line 7: void *(*l1if_open_pdch)(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst * gsmtap); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3662): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/c265a132_873f44e0 PS2, Line 15: void (*use_phy_cb)(struct l1if_phy * phy), bool solitary); "foo * bar" should be "foo *bar"
File src/pcu_l1_if_phy.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3662): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/49dfc0c1_49396121 PS2, Line 21: void (*use_phy_cb)(struct l1if_phy * phy); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3662): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/f7137535_2c1af88e PS2, Line 39: void(*use_phy_cb)(struct l1if_phy * phy), bool solitary) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3662): https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/5dfec9df_2afe0af9 PS2, Line 39: void(*use_phy_cb)(struct l1if_phy * phy), bool solitary) missing space after return type