[M] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks

Attention is currently required from: jolly, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/16f1b6fa_4b9e1736 PS2, Line 15: It was not clear that PAGING : COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the : receiving end Reading this patch again I am not sure if I understand the goal you're aiming to achieve. Yes, RR Immediate Assignment messages sent via PCH do need to be confirmed, but what makes you think that paging requests need to be confirmed too? You're even saying there is a bug, but what exactly is broken? Take a look at `pcu_rx_data_cnf()`. This function checks if the SAPI is `PCU_IF_SAPI_PCH` and calls `bts_rcv_imm_ass_cnf` iff `data_cnf->data[2] == GSM48_MT_RR_IMM_ASS`. AFAICS, no confirmation is expected for paging requests. File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/14fc3dcd_44f3849f PS2, Line 33: The caller must use a TMSI/TLLI Is there anything in the specs. limiting the MI type to TMSI for PS paging? I am not aware of such limitations. TMSI may be unassigned and the MS can be paged by IMSI. This looks wrong to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment