Attention is currently required from: jolly, pespin, dexter.

Patch set 2:Code-Review -1

2 comments:

Commit Message:
- Patch Set #2, Line 15:
```
It was not clear that PAGING
COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the
receiving end
```
  Reading this patch again I am not sure if I understand the goal you're aiming to achieve. Yes, RR Immediate Assignment messages sent via PCH do need to be confirmed, but what makes you think that paging requests need to be confirmed too? You're even saying there is a bug, but what exactly is broken?
  Take a look at `pcu_rx_data_cnf()`. This function checks if the SAPI is `PCU_IF_SAPI_PCH` and calls `bts_rcv_imm_ass_cnf` iff `data_cnf->data[2] == GSM48_MT_RR_IMM_ASS`. AFAICS, no confirmation is expected for paging requests.
File src/gprs_rlcmac.c:
- Patch Set #2, Line 33: The caller must use a TMSI/TLLI
  Is there anything in the specs. limiting the MI type to TMSI for PS paging? I am not aware of such limitations. TMSI may be unassigned and the MS can be paged by IMSI. This looks wrong to me.

To view, visit change 32694. To unsubscribe, or for help writing mail filters, visit settings.