Attention is currently required from: fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32532 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable)
......................................................................
Patch Set 12:
(2 comments)
This change is ready for review.
Patchset:
PS12:
@fixeria: This patch should now be fixed. I have tested it with 1.5 and 2.0.0. I also
followed your suggestion to use inline pylint pragmas but pylint seems to ignore them.
Maybe you have an idea here.
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/32532/comment/11a5db4c_23e9ac80
PS12, Line 162: # pylint: disable=E1121
I have tested this also with too-many-function-args but it seems not to be recognized by
pylint. As far as I understand the documentation this pylint pragma woul dbe valid for the
entire block. I am running out of ideas here, maybe we should not indent using spaces?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32532
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff
Gerrit-Change-Number: 32532
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 May 2023 09:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment