Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email )
Change subject: vty: Allow setting cnlink msc/sgsn name
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/osmo-hnbgw/cnlink.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270/comment/53522ea2_4aee84f0?us... :
PS2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name);
Yeah I thought about that while writing the patch. […]
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic557f20f40fec49ce2c83a73f6e5c8b027d57ef5
Gerrit-Change-Number: 40270
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 12 May 2025 14:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de