[L] Change in osmo-mgw[master]: mgcp_codec: fix codec decision

Attention is currently required from: neels, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 ) Change subject: mgcp_codec: fix codec decision ...................................................................... Patch Set 11: (7 comments) Patchset: PS11: Mostly cosmetic comments, not critical. File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/888d664b_894c4c26 PS11, Line 362: found_same_codec = &rtp_end->codecs[i]; just do: ``` return &rtp_end->codecs[i]; ``` https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/9932e894_1ee3c446 PS11, Line 367: return found_same_codec; ``` return NULL; ``` https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/0cb3b7fb_839d69cb PS11, Line 408: struct mgcp_rtp_codec *codec_conn_dst = NULL; cosmetic: can be moved inside the loop bodies https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/6e40be93_0ee54073 PS11, Line 423: if (conn_dst->end.codecs_assigned == 0) { In order to avoid code duplication, I would merge this block into the previous one: ``` if (!conn_dst || conn_dst->end.codecs_assigned == 0) { ... } ``` File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/949d7d3e_c9040d6e PS11, Line 1808: ws https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/9158dd80_411dfae0 PS11, Line 1976: ws -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5 Gerrit-Change-Number: 32218 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 10:25:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment