Attention is currently required from: neels, pespin, dexter.

View Change

7 comments:

• Patchset:

  • Patch Set #11:

    Mostly cosmetic comments, not critical.

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #11, Line 362: found_same_codec = &rtp_end->codecs[i];

    just do:

    ```
    return &rtp_end->codecs[i];
    ```

  • Patch Set #11, Line 367: return found_same_codec;

    ```
    return NULL;
    ```

  • Patch Set #11, Line 408: struct mgcp_rtp_codec *codec_conn_dst = NULL;

    cosmetic: can be moved inside the loop bodies

  • Patch Set #11, Line 423: if (conn_dst->end.codecs_assigned == 0) {

    In order to avoid code duplication, I would merge this block into the previous one:

    ```
    if (!conn_dst || conn_dst->end.codecs_assigned == 0) { ... }
    ```

• File tests/mgcp/mgcp_test.c:

  • Patch Set #11, Line 1808:

    ws

  • Patch Set #11, Line 1976:

    ws

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.