Attention is currently required from: laforge.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31529 )
Change subject: Interleaving for CSD
......................................................................
Patch Set 2:
(2 comments)
File src/coding/gsm0503_interleaving.c:
https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/a7ffb8ac_91cf2563
PS2, Line 712: j = (k % 19) + 19*(k % 6);
This would look nicer with space around *
https://gerrit.osmocom.org/c/libosmocore/+/31529/comment/87da064b_7251cf93
PS2, Line 723: /* upper bound for B: 4*n + 18 + 4 = 4*n + 22 */
Since index is the same for de/interleaving perhaps it makes sense to split it into static
function to avoid code copy-paste.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31529
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6b16c2d0d7febf3883da662b2c7fec543335de12
Gerrit-Change-Number: 31529
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 25 Feb 2023 21:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment