16 Feb
2023
16 Feb
'23
11:37 a.m.
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31339 )
Change subject: ho: remove timeout for HO_ST_WAIT_LCHAN_ACTIVE
......................................................................
ho: remove timeout for HO_ST_WAIT_LCHAN_ACTIVE
Remove placeholder timer T23042.
Neels wrote:
I think the right thing here is to remove this
timeout; this needs
no timeout at all because we can rely on the lchan_fsm to either
return HO_EV_LCHAN_ACTIVE or HO_EV_LCHAN_ERROR after the usual
timeouts set for lchan activation. IOW since it is internal to
osmo-bsc one of the two events is guaranteed to occur.
If we superimpose a timer on top of the lchan timeouts, configuring
larger lchan activation timeouts becomes complex, because the user
has to take care to also allow a larger timeout for the same
procedure during HO.
Related: OS#5787
Change-Id: Ibf740aaa9bddc2de85cf8087ad90bab47aac12c2
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 0d888e0..3742e46 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -193,7 +193,7 @@
}
static const struct osmo_tdef_state_timeout ho_fsm_timeouts[32] = {
- [HO_ST_WAIT_LCHAN_ACTIVE] = { .T = 23042 },
+ [HO_ST_WAIT_LCHAN_ACTIVE] = { /* Guarded by X5 + X6 in lchan_fsm_timeouts */ },
[HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 },
[HO_ST_WAIT_RR_HO_DETECT] = { .T = 23042 },
[HO_ST_WAIT_RR_HO_COMPLETE] = { .T = 23042 },
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31339
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf740aaa9bddc2de85cf8087ad90bab47aac12c2
Gerrit-Change-Number: 31339
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged