[M] Change in osmo-msc[master]: vlr: add PS support

Attention is currently required from: lynxis lazus, pespin. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 9: Code-Review+1 (2 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/e7c31aa4_d4264ef6?usp… : PS5, Line 771: /*! count times timer T timed out */ i will veto block this patch unless you make this: "Tally times timer T triggered timeout" https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/dd7d5d05_53c9a443?usp… : PS5, Line 1611: fi->T I'm a bit confused about what i meant with my original comment. But I'm also still confused by the two arguments for CS and PS, particularly because there is no VLR that is both CS and PS at the same time, is there? I see in my original comment i tried to find out how by looking for callers... So even though i don't have a good point to make, my gut feel is that this could be less confusing? (if only a comment explaining why this is cool) About the code change you hint, I do see that vlr_timer_secs() says * TODO: we should start using osmo_tdef_fsm_inst_state_chg() */ and that sounds about right to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>