Attention is currently required from: lynxis lazus, pespin.

Patch set 9:Code-Review +1

View Change

2 comments:

• File src/libvlr/vlr_lu_fsm.c:

  • Patch Set #5, Line 771: /*! count times timer T timed out */

    I'm sure whatever else you put in there will be easier to read, that's really a tongue twister.

    i will veto block this patch unless you make this:
    "Tally times timer T triggered timeout"

  • Patch Set #5, Line 1611: fi->T

    In this case, you could also pass -1 to it. […]

    I'm a bit confused about what i meant with my original comment.
    But I'm also still confused by the two arguments for CS and PS, particularly because there is no VLR that is both CS and PS at the same time, is there?
    I see in my original comment i tried to find out how by looking for callers...
    So even though i don't have a good point to make, my gut feel is that this could be less confusing? (if only a comment explaining why this is cool)

    About the code change you hint, I do see that vlr_timer_secs() says

       * TODO: we should start using osmo_tdef_fsm_inst_state_chg() */

    and that sounds about right to me.

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.