Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/35553?usp=email )
Change subject: global_platform: Implement generic store_data command
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File pySim/global_platform.py:
https://gerrit.osmocom.org/c/pysim/+/35553/comment/e3dcba3d_999be2db
PS1, Line 344: opts.response == 'may_be_returned'
The operator `==` already gives `True/False`, so ternary operator is redundant.
https://gerrit.osmocom.org/c/pysim/+/35553/comment/409b2eab_40ae36f0
PS1, Line 361: sw
Do we want to check `sw` here?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/35553?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If30c5d31b4e7dd60d3a5cfb1d1cbdcf61741a50e
Gerrit-Change-Number: 35553
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 12 Jan 2024 10:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment