[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

Jenkins Builder has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 1: (29 comments) File src/osmo-bsc/bts_nokia_site.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/12154456_4e0d81b9?usp… : PS1, Line 1137: switch (hopping_type) { switch and case should be at the same indent File src/osmo-bsc/bts_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/658f9929_9242d19e?usp… : PS1, Line 469: cfg_bts_nokia_site_hopping_type_cmd, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d3e9c9c3_a57e5e62?usp… : PS1, Line 469: cfg_bts_nokia_site_hopping_type_cmd, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/936bc0ef_d42eabf5?usp… : PS1, Line 470: "nokia_site nokia_hopping (0|1)", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/6c34df9f_b55ae118?usp… : PS1, Line 470: "nokia_site nokia_hopping (0|1)", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/45aa982e_4689318b?usp… : PS1, Line 471: NOKIA_STR code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/cb91dca0_007a17e0?usp… : PS1, Line 471: NOKIA_STR please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/cf115d0d_e2f49dcf?usp… : PS1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e2b9498c_f7b56bc1?usp… : PS1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/946f4a9b_b5bf97d5?usp… : PS1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d967ca2b_0aa1cbe7?usp… : PS1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/f2c378fa_78b8a635?usp… : PS1, Line 474: CMD_ATTR_IMMEDIATE) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/f411af94_fb316456?usp… : PS1, Line 474: CMD_ATTR_IMMEDIATE) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e33bbbdb_2e11dec6?usp… : PS1, Line 476: struct gsm_bts *bts = vty->index; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/257e62d8_c43a662b?usp… : PS1, Line 476: struct gsm_bts *bts = vty->index; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/713a4a4e_a54e687b?usp… : PS1, Line 478: if (!is_nokia_bts(bts)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/2243de2e_3d2b06ba?usp… : PS1, Line 478: if (!is_nokia_bts(bts)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/783d1560_87e9a727?usp… : PS1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/334dd2fc_f9e2d4cb?usp… : PS1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s", please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/05698914_f15da317?usp… : PS1, Line 480: VTY_NEWLINE); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/23e88df5_fbadb913?usp… : PS1, Line 480: VTY_NEWLINE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/c7635a0d_a1bc4354?usp… : PS1, Line 481: return CMD_WARNING; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/49bb6f26_80f4886a?usp… : PS1, Line 481: return CMD_WARNING; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/4ec5c987_dd158407?usp… : PS1, Line 482: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d4df6351_c60a6266?usp… : PS1, Line 482: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/1f2c7fb3_c1fa0c50?usp… : PS1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/4a2d7537_482dfc8f?usp… : PS1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/e142ea38_f6e70c6f?usp… : PS1, Line 486: return CMD_SUCCESS; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868): https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/52b69d58_eb367d30?usp… : PS1, Line 486: return CMD_SUCCESS; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 11 Jan 2025 18:09:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No