29 comments:
File src/osmo-bsc/bts_nokia_site.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 1137: switch (hopping_type) {
switch and case should be at the same indent
File src/osmo-bsc/bts_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 469: cfg_bts_nokia_site_hopping_type_cmd,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 469: cfg_bts_nokia_site_hopping_type_cmd,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 470: "nokia_site nokia_hopping (0|1)",
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 470: "nokia_site nokia_hopping (0|1)",
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 471: NOKIA_STR
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 471: NOKIA_STR
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n"
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 472: "This parameter sets the frequency hopping type for Nokia *Site\n"
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n",
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 473: "0=Baseband hopping, 1=Synthesizer (RF) hopping\n",
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 474: CMD_ATTR_IMMEDIATE)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 474: CMD_ATTR_IMMEDIATE)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 476: struct gsm_bts *bts = vty->index;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 476: struct gsm_bts *bts = vty->index;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 478: if (!is_nokia_bts(bts)) {
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 478: if (!is_nokia_bts(bts)) {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s",
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 479: vty_out(vty, "%% BTS is not of Nokia *Site type%s",
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 480: VTY_NEWLINE);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 480: VTY_NEWLINE);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 481: return CMD_WARNING;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 481: return CMD_WARNING;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 484: bts->nokia.nokia_hopping = atoi(argv[0]);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 486: return CMD_SUCCESS;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20868):
Patch Set #1, Line 486: return CMD_SUCCESS;
please, no spaces at the start of a line
To view, visit change 39290. To unsubscribe, or for help writing mail filters, visit settings.